Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in "build_dataset" function #85

Closed
JieyuZ2 opened this issue Feb 24, 2023 · 1 comment
Closed

bug in "build_dataset" function #85

JieyuZ2 opened this issue Feb 24, 2023 · 1 comment

Comments

@JieyuZ2
Copy link

JieyuZ2 commented Feb 24, 2023

The following line will cause error when the task is "linear_probe", because the code only load classnames, templates when task is zeroshot, but the classnames would be used in the following line no matter what task it is....

CLIP_benchmark/clip_benchmark/datasets/builder.py

Line 92 in c4d9927

ds.classes = classnames["imagenet1k"]

@mehdidc
Copy link
Collaborator

mehdidc commented Mar 2, 2023

Thanks @JieyuZ2 ! will fix this

mehdidc added a commit that referenced this issue Mar 2, 2023
@mehdidc
Fix issues #82, #83, #84, #85. Thanks to @JieyuZ2, @SingL3, @jackee777
ee34649
mehdidc added a commit that referenced this issue Mar 2, 2023
@mehdidc
Fix issues #82, #83, #84, #85. Thanks to @JieyuZ2, @SingL3, @jackee777 (
2859782 
#86)
@JieyuZ2 JieyuZ2 closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mehdidc @JieyuZ2