Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log dataset and model in new cli #76

Closed
rom1504 opened this issue Feb 3, 2023 · 5 comments
Closed

log dataset and model in new cli #76

rom1504 opened this issue Feb 3, 2023 · 5 comments
Labels
documentation Improvements or additions to documentation

Comments

@rom1504
Copy link
Contributor

rom1504 commented Feb 3, 2023

run.sh had that and it was nice to know progress

@rom1504 rom1504 added the documentation Improvements or additions to documentation label Feb 3, 2023
@djghosh13
Copy link
Contributor

Do you mean just printing out model/dataset/progress percent after each one?

@djghosh13
Copy link
Contributor

It looks like the dataset, model, and language (but not progress percent) are already printed out if you use --verbose

@rom1504
Copy link
Contributor Author

rom1504 commented Feb 3, 2023

opinion on removing verbose option and making it the default ?

@djghosh13
Copy link
Contributor

I don't have a strong opinion one way or the other, but if we wanted to make that change, we could replace

parser_eval.add_argument('--verbose', default=False, action="store_true", help="verbose mode")

with

parser_eval.add_argument('--quiet', dest='verbose', action="store_false", help="suppress verbose messages")

to just flip the default verbosity (and also rename the cli option name correspondingly).

@rom1504
Copy link
Contributor Author

rom1504 commented Feb 3, 2023

yeah #78

@rom1504 rom1504 closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants