Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug with paths #49

Closed
rom1504 opened this issue Dec 7, 2022 · 7 comments
Closed

fix bug with paths #49

rom1504 opened this issue Dec 7, 2022 · 7 comments

Comments

@rom1504
Copy link
Contributor

rom1504 commented Dec 7, 2022

for example

/fsx/rom1504/CLIP_benchmark/clip_benchmark/datasets/vtab/svhn_classnames.json

trying to get the file from current dir instead of dataset dir

@FreddeFrallan @djghosh13

@djghosh13
Copy link
Contributor

What exactly do you mean? From what I can tell, the classnames JSON file is meant to be loaded from the folder that CLIP_benchmark was installed to (which is what is happening for me), and not from the dataset directory. Are you saying you'd prefer it read from the dataset directory?

@rom1504
Copy link
Contributor Author

rom1504 commented Dec 8, 2022

It used to be read from the dataset directory yes
Otherwise that means the files are all over the place no ?

Not sure when that changed, i guess a few commits back ?

@djghosh13
Copy link
Contributor

Yeah, I guess so (I've only been using the library for the last few weeks). But I wouldn't say they're all over the place, it's just the classnames and zeroshot templates files stored in the CLIP_benchmark folder, and the data stored in the data folder, right?

Though this does differ from the webdataset setup we decided on where those are all stored together. I guess the importance of that distinction is whether people should easily be able to change the classnames/templates or not. So maybe we do want to move those back with the datasets.

@rom1504
Copy link
Contributor Author

rom1504 commented Dec 8, 2022

it's just the classnames and zeroshot templates files stored in the CLIP_benchmark folder, and the data stored in the data folder, right?

I'm not talking about the classnames that are currently committed to the repo, but about the ones automatically downloaded by the tool. Those should be in dataset folder

@rom1504
Copy link
Contributor Author

rom1504 commented Dec 8, 2022

The ones in the repo are a different kind, kind of an override

@djghosh13
Copy link
Contributor

I see, this is entirely different then.

@rom1504
Copy link
Contributor Author

rom1504 commented Dec 13, 2022

fixed

@rom1504 rom1504 closed this as completed Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants