-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug with paths #49
Comments
What exactly do you mean? From what I can tell, the classnames JSON file is meant to be loaded from the folder that CLIP_benchmark was installed to (which is what is happening for me), and not from the dataset directory. Are you saying you'd prefer it read from the dataset directory? |
It used to be read from the dataset directory yes Not sure when that changed, i guess a few commits back ? |
Yeah, I guess so (I've only been using the library for the last few weeks). But I wouldn't say they're all over the place, it's just the classnames and zeroshot templates files stored in the CLIP_benchmark folder, and the data stored in the data folder, right? Though this does differ from the webdataset setup we decided on where those are all stored together. I guess the importance of that distinction is whether people should easily be able to change the classnames/templates or not. So maybe we do want to move those back with the datasets. |
I'm not talking about the classnames that are currently committed to the repo, but about the ones automatically downloaded by the tool. Those should be in dataset folder |
The ones in the repo are a different kind, kind of an override |
I see, this is entirely different then. |
fixed |
for example
/fsx/rom1504/CLIP_benchmark/clip_benchmark/datasets/vtab/svhn_classnames.json
trying to get the file from current dir instead of dataset dir
@FreddeFrallan @djghosh13
The text was updated successfully, but these errors were encountered: