Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version check so that CI tests pass #27

Open
bburan opened this issue Jan 30, 2023 · 1 comment
Open

Fix version check so that CI tests pass #27

bburan opened this issue Jan 30, 2023 · 1 comment

Comments

@bburan
Copy link
Collaborator

bburan commented Jan 30, 2023

https://github.com/LABSN/tdtpy/blob/c7b2eaaec207dd4371749815c7ad3f91243843d5/.github/workflows/tests.yml#L29:L32

  - run: |
      python -c "import tdt; print(tdt.__version__); assert 'dev' in tdt.__version__"
    name: Check versioning
    if: "!contains(github.event.head_commit.message, '[version skip]')"

Is this check still necessary now that we are using setuptools_scm?

@larsoner
Copy link
Member

It was actually put there specifically to make sure we don't end up with something bad like 0.0.0 when using setuptools_scm.

It will fail on releases, though, it would be nice to avoid that -- maybe by making it skip that run when on a tag or whatever. Or we just ignore the failure of that step on releases...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants