Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Adds heartbeat to prevent Websocket closing #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds heartbeat to prevent Websocket closing #13

wants to merge 1 commit into from

Conversation

RobertLowe
Copy link

This change ensures Firefox (and others?) don't close connection when detected as idle with a CloseEvent of 1006. This is an opinionated change due to when using ws.onclose on the client. This is entirely committed for note and posterity.

Cheers

This change ensures Firefox (and others?) don't close connection when detected as idle with a CloseEvent of 1006. This is an opinionated change due to when using `ws.onclose` on the client. This is entirely committed for note and posterity.
@jenkinskurento
Copy link

Hi there. Thanks for your PR.

I'm waiting for a Kurento member to verify that this patch is reasonable to test. If it is, they should reply with check out please on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

@jenkinskurento
Copy link

There were no errors, go have a cup of coffee...

1 similar comment
@jenkinskurento
Copy link

There were no errors, go have a cup of coffee...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants