Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion]: Evaluate .NET 9 Release Candidates and General Availability Release Breaking Changes #1777

Open
giduac opened this issue Sep 17, 2024 · 7 comments
Assignees
Labels
discussion Discussion thread. other All other issues. version:95 All things to do with V95. version:100 All things to do with V100.
Milestone

Comments

@giduac
Copy link
Contributor

giduac commented Sep 17, 2024

Evaluate breaking changes for DN9:

Investigate the remediation of warning WFO1000
Will be handled in Issue #1840

The .NET error WFO1000 was introduced in .NET 9 RC-1 and occurs primarily in WinForms applications. It signifies that a property within a component is not properly configured for serialization. This issue arises when properties lack appropriate serialization attributes, causing the application to throw the error during compilation.

The DesignerSerializationVisibility enum in .NET is used to control how a property or event is serialized by the designer (like the Visual Studio designer) into the source code. It has three options:

Visible (DesignerSerializationVisibility.Visible):
The property or event is serialized by the designer.
This is the default setting and is used for properties that should appear in the designer’s generated code.
When set to Visible, the designer serializes the property's value, enabling it to be saved in the form's code and restored at runtime.

Hidden (DesignerSerializationVisibility.Hidden):
The property or event is not serialized by the designer.
Properties set to Hidden are ignored by the designer, meaning their values will not be saved to the form’s generated code, even if you set them in the designer.
This setting is used for properties that are calculated or transient, or for those that don’t need to be persisted.

Content (DesignerSerializationVisibility.Content):
The designer serializes the contents of the property, rather than the property itself.
This is typically used for complex properties like collections or custom types with nested properties. When set to Content, the designer serializes each item or subproperty within the property instead of the entire property.
This is useful for properties that contain a collection of items (e.g., a list of buttons within a panel), allowing each item to be individually serialized.

Winforms: BindingSource.SortDescriptions doesn't return null

Changes to nullability annotations (Windows Forms)



ComponentDesigner.Initialize throws ArgumentNullException

DataGridViewRowAccessibleObject.Name starting row index

IMsoComponent support is opt-in

New Security Analyzers

No exception if DataGridView is null

PictureBox raises HttpClient exceptions

@giduac giduac added discussion Discussion thread. other All other issues. labels Sep 17, 2024
@giduac giduac added under investigation This bug/issue is currently under investigation. need more info Needs more information to better understand the issue. labels Sep 17, 2024
@giduac
Copy link
Contributor Author

giduac commented Sep 18, 2024

@Smurf-IV, @PWagner1 & @Ahmed-Abdelhameed,

I'm getting reluctant to go full throttle on .NET 9 RC1 at this point.
dotnet/sdk#43339

I think we should evaluate the breaking changes and see what needs to be done on the toolkit and can prepare what is possible ahead of RC2.

From there we wait until RC2 is released to see if that proves stable.

@Smurf-IV
Copy link
Member

From there we wait until RC2 is released to see if that proves stable.

Agreed.

@Smurf-IV Smurf-IV added this to the Version 90 milestone Sep 18, 2024
@Smurf-IV Smurf-IV added the version:90 All things to do with V90. label Sep 18, 2024
@giduac
Copy link
Contributor Author

giduac commented Sep 19, 2024

Hi @PWagner1, @Smurf-IV & @Ahmed-Abdelhameed,

I've updated the topic start with my findings so far.

Can you all please evaluate the Breaking changes for yourselves and see what needs to be done?

@giduac giduac added the awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. label Sep 19, 2024
@giduac
Copy link
Contributor Author

giduac commented Oct 8, 2024

Hi @PWagner1, @Smurf-IV & @Ahmed-Abdelhameed,

I've updated the topic start with my findings so far.

Can you all please evaluate the Breaking changes for yourselves and see what needs to be done?

@giduac
Copy link
Contributor Author

giduac commented Oct 11, 2024

@PWagner1 @Smurf-IV @Ahmed-Abdelhameed,

Topic start updated...

@PWagner1
Copy link
Contributor

Only the two highlighted

@PWagner1 PWagner1 added version:95 All things to do with V95. and removed version:90 All things to do with V90. labels Oct 21, 2024
@giduac
Copy link
Contributor Author

giduac commented Nov 24, 2024

Checks for DN9 breaking changes have been completed.
Two PRs need to be added to V95 as soon as V100 PRs prove to be correct.

We'll check on that later in December so we can get it in V95 Patch 1.

@giduac giduac added version:100 All things to do with V100. and removed awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. under investigation This bug/issue is currently under investigation. need more info Needs more information to better understand the issue. labels Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion thread. other All other issues. version:95 All things to do with V95. version:100 All things to do with V100.
Projects
None yet
Development

No branches or pull requests

4 participants