Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check date range when defined #112

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

inode64
Copy link
Contributor

@inode64 inode64 commented Apr 14, 2023

It can happen and it has happened to me, that the date of the videos recorded by the gopro is in the future and now they are not imported

I have created a function to group the check of date ranges and it only checks the dates in case they contain any value

Type:

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Camera:

  • GoPro
  • Insta360
  • DJI
  • Android
  • This PR adds a new camera

Component:

  • Core logic
  • Import
  • Merging
  • Firmware Update
  • Video Manipulation

Checklist before approval:

  • Linter pass
  • Build pass

…recorded by the gopro is in the future and now they are not imported

I have created a function to group the check of date ranges and it only checks the dates in case they contain any value
@inode64
Copy link
Contributor Author

inode64 commented Apr 15, 2023

By the way, I have seen https://github.com/markusmobius/go-dateparser which may be interesting for date management, which is a more advanced function,
If you want you can modify the code to add it
How about?

@KonradIT
Copy link
Owner

Go's date parser is already pretty good.

@KonradIT
Copy link
Owner

I have to test this extensively before merging.

@inode64
Copy link
Contributor Author

inode64 commented Apr 16, 2023

For now, it did not include more changes.
I propose the markusmobius/go-dateparser library for another pull request.

@KonradIT KonradIT added the needs-testing Needs testing on my end label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-testing Needs testing on my end
Projects
Status: Needs testing / review
Development

Successfully merging this pull request may close these issues.

2 participants