fix(tracing): bar calculation and start and end time in span attributes #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is mainly for these changes:
Showing the start and end date and time of the selected span in the "Span attributes" section in ISO 8601 format with nanosecond precision (KM-797):
Fixed the width and position calculation for span bars (KM-808):
The minimal width of a span bar was adjusted to
1pxto show the spans with a relatively short duration more accurately.Highlighting the span rows on hover (using the same color as the selected rows is intended)
Other changes:
SpanAttributeKeysfor string-based keys for span attributesSpanAttributeSchemanow expresses the type and usage in sampling rules of span attributes in a more structured way