Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(entities-plugins): add default values in protocols placeholder #1722

Merged
merged 1 commit into from
Oct 16, 2024
Merged

feat(entities-plugins): add default values in protocols placeholder #1722

merged 1 commit into from
Oct 16, 2024

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Oct 16, 2024 •
edited
Loading

Summary

In plugin forms:

  1. Adding default values to the placeholder of the protocols field in GM
  2. Removing all default values from placeholders in KM
GM KM
image image

KM-526

@Leopoldthecoder Leopoldthecoder requested review from a team as code owners October 16, 2024 08:31
Justineo
Justineo approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@Justineo Justineo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think we should create a ticket to track the different behavior between KM/GM.

@Leopoldthecoder
Copy link
Member Author

LGTM

I think we should create a ticket to track the different behavior between KM/GM.

Do you think we need a KM ticket in addition to https://konghq.atlassian.net/browse/KAG-5576?

@Justineo
Copy link
Contributor

Maybe create one for frontend changes on our side and link it to KAG-5576?

@Leopoldthecoder
Copy link
Member Author

Created https://konghq.atlassian.net/browse/KM-600

@Leopoldthecoder Leopoldthecoder merged commit 81a12d5 into main Oct 16, 2024
9 checks passed
@Leopoldthecoder Leopoldthecoder deleted the feat/protocols-placeholder branch October 16, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justineo Justineo Justineo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leopoldthecoder @Justineo