Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(entities-plugins): plugin list display incorrect scopes [KM-591] #1720

Closed
wants to merge 1 commit into from
Closed

fix(entities-plugins): plugin list display incorrect scopes [KM-591] #1720

wants to merge 1 commit into from

Conversation

2eha0
Copy link
Contributor

@2eha0 2eha0 commented Oct 16, 2024 •
edited by jira bot
Loading

Summary

Compatible with different data structures in the List and Filter APIs
KM-591

@2eha0 2eha0 marked this pull request as ready for review October 16, 2024 06:14
@2eha0 2eha0 requested review from a team as code owners October 16, 2024 06:14
@Leopoldthecoder
Copy link
Member

Leopoldthecoder commented Oct 16, 2024 •
edited by jira bot
Loading

Summary

Compatible with different data structures in the List and Filter APIs KM-591

I think it should be KM-590

TT1228
TT1228 reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@TT1228 TT1228 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can apply same logic by taking row.consumer_id and row.consumer_group_id into account. I've observed same problem on consumer and consumer group scoped plugins
截屏2024-10-16 下午2 27 58

@2eha0 2eha0 closed this Oct 16, 2024
@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/entities-plugins@pr-1720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TT1228 TT1228 TT1228 left review comments

@adamdehaven adamdehaven Awaiting requested review from adamdehaven

@jillztom jillztom Awaiting requested review from jillztom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2eha0 @Leopoldthecoder @kongponents-bot @TT1228