Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(portal): hide default tag when all tagged [TDX-4666] #1719

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

amerc15
Copy link
Contributor

@amerc15 amerc15 commented Oct 15, 2024

Summary

https://konghq.atlassian.net/browse/TDX-4666

When all endpoints had tags the default section would appear with nothing in it. So do not render the section when there are no untagged endpoints.

@amerc15 amerc15 requested review from a team as code owners October 15, 2024 18:40
@CLAassistant
Copy link

CLAassistant commented Oct 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@Mierenga Mierenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andrewwylde andrewwylde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@amerc15 amerc15 merged commit 5d37392 into main Oct 15, 2024
9 checks passed
@amerc15 amerc15 deleted the feat/TDX-4666-hide-default-tag-when-all-tagged branch October 15, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants