feat(entities-plugins): add default values in protocols placeholder (#…

…1722)
Kong · Oct 16, 2024 · 81a12d5 · 81a12d5
1 parent 262e6f9
commit 81a12d5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/packages/entities/entities-plugins/src/components/PluginForm.vue b/packages/entities/entities-plugins/src/components/PluginForm.vue
@@ -466,7 +466,6 @@ const defaultFormSchema: DefaultPluginsSchemaRecord = reactive({
     default: [],
     help: t('plugins.form.fields.protocols.help'),
     label: t('plugins.form.fields.protocols.label'),
-    placeholder: t('plugins.form.fields.protocols.placeholder'),
     required: true,
     styleClasses: 'plugin-protocols-select',
     type: 'multiselect',
@@ -852,7 +851,8 @@ const buildFormSchema = (parentKey: string, response: Record<string, any>, initi
 
     // Field type is an input, determine input type, such as 'text', or 'number'
     if (initialFormSchema[field].type === 'input') {
-      if (['string', 'number'].includes(typeof initialFormSchema[field].default)) {
+      if (['string', 'number'].includes(typeof initialFormSchema[field].default) && props.config.app === 'konnect') {
+        // Konnect API respects default values if the field is not set, so display them in the placeholder
         initialFormSchema[field].placeholder = `Default: ${
           initialFormSchema[field].default === '' ? '<empty string>' : initialFormSchema[field].default
         }`
@@ -1274,6 +1274,13 @@ onBeforeMount(async () => {
 
             defaultFormSchema.protocols.default = defaultValues
 
+            // Konnect API respects default values if the field is not set, so display them in the placeholder
+            defaultFormSchema.protocols.placeholder = props.config.app === 'konnect'
+              ? t('plugins.form.fields.protocols.placeholderWithDefaultValues', {
+                protocols: defaultValues.join(', '),
+              })
+              : t('plugins.form.fields.protocols.placeholder')
+
             if (elements.one_of?.length) {
               defaultFormSchema.protocols.values = elements.one_of.map((value: string) => ({ label: value, value }))
             }

diff --git a/packages/entities/entities-plugins/src/locales/en.json b/packages/entities/entities-plugins/src/locales/en.json
@@ -534,6 +534,7 @@
         "protocols": {
           "label": "Protocols",
           "placeholder": "Select valid protocols for the plugin",
+          "placeholderWithDefaultValues": "Select valid protocols for the plugin. Default protocols: {protocols}",
           "help": "A list of the request protocols that will trigger this plugin. The default value, as well as the possible values allowed on this field, may change depending on the plugin type."
         }
       },