Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps) bump Wasmer to 4.1.2 #404

Closed
wants to merge 2 commits into from
Closed

Conversation

thibaultcha
Copy link
Member

@thibaultcha thibaultcha commented Aug 29, 2023

Mostly so not to fall too far behind and see what CI says.

@thibaultcha
Copy link
Member Author

# Test 1
$ ./util/test.sh t/01-wasm/hfuncs/wasi/000-non_host_wasi.t
2023/08/30 11:29:09 [debug] 2776307#0: *1 wasm ops calling "wasi_vm_tests.test_wasi_non_host" in "rewrite" phase
2023/08/30 11:29:09 [debug] 2776307#0: *1 wasm creating "wasi_vm_tests" instance in "main" vm
thread '<unnamed>' panicked at 'wasmer_env_set_memory() is not supported', lib/c-api/src/wasm_c_api/wasi/mod.rs:390:5
stack backtrace:
   0: rust_begin_unwind
             at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/std/src/panicking.rs:579:5
   1: core::panicking::panic_fmt
             at /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/core/src/panicking.rs:64:14
   2: wasi_env_set_memory
   3: ngx_wasmer_init_extern
             at ./src/wasm/wrt/ngx_wrt_wasmer.c:695:13
   4: ngx_wavm_instance_create
             at ./src/wasm/vm/ngx_wavm.c:993:14
   5: ngx_wasm_op_call_handler
             at ./src/wasm/ngx_wasm_ops.c:350:16
   6: ngx_wasm_ops_resume
             at ./src/wasm/ngx_wasm_ops.c:293:14
   7: ngx_http_wasm_rewrite_handler
             at ./src/http/ngx_http_wasm_module.c:675:10
   8: ngx_http_core_rewrite_phase
             at ./work/nginx-patched/src/http/ngx_http_core_module.c:929:10
   9: ngx_http_core_run_phases
             at ./work/nginx-patched/src/http/ngx_http_core_module.c:875:14
  10: ngx_http_handler
             at ./work/nginx-patched/src/http/ngx_http_core_module.c:858:5
  11: ngx_http_process_request
             at ./work/nginx-patched/src/http/ngx_http_request.c:2127:5
  12: ngx_http_process_request_headers
             at ./work/nginx-patched/src/http/ngx_http_request.c:1529:13
  13: ngx_http_process_request_line
             at ./work/nginx-patched/src/http/ngx_http_request.c:1196:13
  14: ngx_http_wait_request_handler
             at ./work/nginx-patched/src/http/ngx_http_request.c:523:5
  15: ngx_epoll_process_events
             at ./work/nginx-patched/src/event/modules/ngx_epoll_module.c:901:17
  16: ngx_process_events_and_timers
             at ./work/nginx-patched/src/event/ngx_event.c:248:12
  17: ngx_single_process_cycle
             at ./work/nginx-patched/src/os/unix/ngx_process_cycle.c:300:9
  18: main
             at ./work/nginx-patched/src/core/nginx.c:381:9
  19: __gconv_transform_ucs4le_internal
             at /usr/src/debug/glibc/glibc/iconv/../iconv/skeleton.c:786:4
  20: ucs4le_internal_loop_single
             at /usr/src/debug/glibc/glibc/iconv/gconv_simple.c:755:46
  21: __gconv_transform_ucs4le_internal
             at /usr/src/debug/glibc/glibc/iconv/../iconv/skeleton.c:565:15
  22: _start

@thibaultcha thibaultcha added pr/work-in-progress PR: Work in progress and removed pr/work-in-progress PR: Work in progress labels Sep 7, 2023
@thibaultcha thibaultcha force-pushed the chore/bump-wasmer branch 2 times, most recently from eec2700 to 5a0e198 Compare September 12, 2023 04:17
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6154992301

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 91.074%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/wasm/wrt/ngx_wrt_wasmer.c 2 3 66.67%
Totals Coverage Status
Change from base Build 6123274751: -0.009%
Covered Lines: 7581
Relevant Lines: 8324

💛 - Coveralls

@thibaultcha thibaultcha added the pr/on-hold PR: Do not merge/close label Sep 12, 2023
@thibaultcha thibaultcha deleted the chore/bump-wasmer branch September 12, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/on-hold PR: Do not merge/close
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants