Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lib): make Rust module compile-able under stable Rust #393

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

dndx
Copy link
Member

@dndx dndx commented Aug 22, 2023

Implementation based on the Rust standard library implementation for vec_into_raw_parts.

See examples from: https://doc.rust-lang.org/src/alloc/vec/mod.rs.html#538-546
Implementation in: https://doc.rust-lang.org/src/alloc/vec/mod.rs.html#818-822

With this change the Rust library now compiles cleanly with stable Rust 1.71.1.

This makes building under a production setup easier as Rust nightly can not be easily pinned and might introduce breaking changes without notice.

Helps unblock: #392

@dndx
Copy link
Member Author

dndx commented Aug 22, 2023

cc @fffonion

@dndx dndx force-pushed the style/stable_rust branch 3 times, most recently from 2bdaea5 to ef1ada8 Compare August 22, 2023 15:04
@dndx dndx force-pushed the style/stable_rust branch from ef1ada8 to 7f5407d Compare August 22, 2023 15:18
@dndx dndx marked this pull request as draft August 22, 2023 15:34
@dndx dndx force-pushed the style/stable_rust branch 2 times, most recently from 41d1a13 to d832def Compare August 22, 2023 15:41
@coveralls
Copy link

coveralls commented Aug 22, 2023

Pull Request Test Coverage Report for Build 5941536595

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.123%

Totals Coverage Status
Change from base Build 5910032552: 0.0%
Covered Lines: 7586
Relevant Lines: 8325

💛 - Coveralls

Implementation based on the Rust standard library implementation
for `vec_into_raw_parts`.
@dndx dndx force-pushed the style/stable_rust branch from d832def to 72647e7 Compare August 22, 2023 16:30
@dndx dndx marked this pull request as ready for review August 22, 2023 16:31
@thibaultcha thibaultcha added the pr/merge-in-progress PR: Merge in progress (do not push) label Aug 22, 2023
@thibaultcha thibaultcha merged commit d9ce69d into Kong:main Aug 22, 2023
@dndx dndx deleted the style/stable_rust branch August 23, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/merge-in-progress PR: Merge in progress (do not push)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants