chore(config) better support NGX_WASM_CARGO=0 #386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing NGX_WASM_CARGO=0 variable already allows skipping the Cargo step for building ngx-wasm-rs during `./configure`, but it didn't set the defines needed for each VM configuration. This commit adds the defines when NGX_WASM_CARGO=0 is used, allowing the user to build ngx-wasm-rs separately if wanted, passing its header and library locations via NGX_BUILD_CC_OPTS and NGX_BUILD_LD_OPTS, or via `--cc-opts` and `--ld-opts` flags in the nginx `configure` script. Includes tests and documentation.
Pull Request Test Coverage Report for Build 5891642789
💛 - Coveralls |
thibaultcha
changed the title
|
Merged but I moved the documentation to INSTALL.md since it is end-user facing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing NGX_WASM_CARGO=0 variable already allows skipping the Cargo step for building ngx-wasm-rs during
./configure, but it didn't set the defines needed for each VM configuration.This commit adds the defines when NGX_WASM_CARGO=0 is used, allowing the user to build ngx-wasm-rs separately if wanted, passing its header and library locations via NGX_BUILD_CC_OPTS and NGX_BUILD_LD_OPTS, or via
--cc-optsand--ld-optsflags in the nginxconfigurescript.Includes tests and documentation.
(Nevermind the branch name, the approach taken changed halfway through 😆 )