Internalize a Go SDK I/O test case + prevent bad dispatch requests #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5817420381
💛 - Coveralls |
thibaultcha
force-pushed
the
tests/internalize-go-dispatch
branch
2 times, most recently
from
22c6fa4
to
7ea44b7
Compare
casimiro
reviewed
Aug 9, 2023
| location /uuid { | ||
| # Generating a uuid seems excessive; $request_id has some | ||
| # randomness on a distribution of runs of this test. | ||
| echo $request_id; | ||
| } | ||
| } |
thibaultcha
force-pushed
the
tests/internalize-go-dispatch
branch
3 times, most recently
from
e3594b2
to
adb9a44
Compare
hishamhm
reviewed
Aug 9, 2023
| @@ -51,7 +51,7 @@ pushd $DIR_PROXY_WASM_GO_SDK | |||
| ) | |||
|
|
|||
| -const clusterName = "httpbin" | |||
| +const clusterName = "httpbin.org" | |||
| +const clusterName = "httpbin:2000" | |||
thibaultcha
force-pushed
the
tests/internalize-go-dispatch
branch
2 times, most recently
from
7649e4e
to
e4e2c86
Compare
…onnection headers
Currently the most unreliable test case in CI. Pin it to port 2000 (arbitrary)
thibaultcha
force-pushed
the
tests/internalize-go-dispatch
branch
from
e4e2c86
to
85d5c2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.