New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constant time compare would be safer #4

Open

alokmenghrajani opened this issue Jul 5, 2022 · 0 comments

alokmenghrajani commented Jul 5, 2022

https://github.com/Kong/go-srp/blob/master/server.go#L55 should probably use crypto/subtle's ConstantTimeCompare. I'm guessing leaking timing is not exploitable in most contexts but you never know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment