Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why defaults don't match the github doc? #799

Open
penja opened this issue Jul 1, 2019 · 3 comments · May be fixed by #1116
Open

Why defaults don't match the github doc? #799

penja opened this issue Jul 1, 2019 · 3 comments · May be fixed by #1116
Milestone

Comments

@penja
Copy link

penja commented Jul 1, 2019

For example current user api handler link in type field has owner value as default but according github api we link have all as default.

P.S If necessary, I can fix it by PR.

Thanks for this awesome library.

@penja penja changed the title Why defaults don't math the github doc? Why defaults don't match the github doc? Jul 1, 2019
@GrahamCampbell
Copy link
Contributor

Changing this would be a breaking change, so I don't think we should.

@penja
Copy link
Author

penja commented Jul 1, 2019

Ok thanks we can close this issue.

@acrobat
Copy link
Collaborator

acrobat commented Aug 5, 2019

It would indeed be a BC break to change that value now, but maybe a better solution is to move these options into a parameters/options parameter of the function and leave all option empty by default so they will fallback to github defaults.
This way our lib doesn't set defaults that will be outdated sometime in the future.

I will assign the 3.0 milestone to this issue, so we can handle this possible cleanup in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants