Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .phpstorm.meta.php to improve code completion #1092

Open
pronskiy opened this issue Nov 6, 2022 · 1 comment · May be fixed by #1113
Open

Add .phpstorm.meta.php to improve code completion #1092

pronskiy opened this issue Nov 6, 2022 · 1 comment · May be fixed by #1113

Comments

@pronskiy
Copy link

pronskiy commented Nov 6, 2022

Folks, adding a .phpstorm.meta.php file with something like this below, would make users' experience with the package in PhpStorm a bit better when using calls like ->api('issue'):

<?php
namespace PHPSTORM_META {
    override( \Github\Client::api(0),
      map( [
        "issue" => \Github\Api\Issue::class,
        //...
    ]));
}

Would you be interested in adding it?

@acrobat
Copy link
Collaborator

acrobat commented Nov 15, 2022

Users can also use the ->issue() virtual method on the client object and receive full ide support. But indeed this would improve the UX when using the ->api('xxx') approach so I'm open for a PR that adds this improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants