Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple binaries mis-documented #44

Open
Shamazo opened this issue Feb 13, 2021 · 3 comments
Open

Support for multiple binaries mis-documented #44

Shamazo opened this issue Feb 13, 2021 · 3 comments

Comments

@Shamazo
Copy link

Shamazo commented Feb 13, 2021

I am trying to use configure_me for a crate with two executables each with their own config files.
This section in the documentation seems wrong:

# config for binary foo
[package.metadata.configure_me.bin]
foo = "foo_config_spec.toml"

# config for binary bar
[package.metadata.configure_me.bin]
bar = "bar_config_spec.toml"

I believe it should be

# config for binary foo
[package.metadata.configure_me.bin]
foo = "foo_config_spec.toml"
bar = "bar_config_spec.toml"

I can open a PR for this later.

@Shamazo
Copy link
Author

Shamazo commented Feb 13, 2021

Also went digging for how switches work, will add that to the PR.

@Kixunil
Copy link
Owner

Kixunil commented Feb 13, 2021

If I remember correctly that should work with Toml but what you suggest looks better, so I will be happy for a PR. Thanks!

I just have to go now, will review the PR in a couple of hours.

@Shamazo
Copy link
Author

Shamazo commented Feb 14, 2021

no rush, I'll put one up tomorrow most likely. I spent a decent amount of time today digging through the code and may as well write down what I learned so this crate is easier to use for others.

I don't still have the error in my terminal scroll back, but it was something about redefining a table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants