You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you, looks good. Nitpick: instead of using if(APPLE) at two different places, it would be nicer to set a variable like PLATFORM_SUPPORTS_VR once (set it to FALSE if APPLE, TRUE otherwise) and use that value at both places. I did not introduce this variable in the original commit because the check was done at one place and it was possible to explain that in a comment there.
Thank you, looks good. Nitpick: instead of using
if(APPLE)
at two different places, it would be nicer to set a variable likePLATFORM_SUPPORTS_VR
once (set it to FALSE if APPLE, TRUE otherwise) and use that value at both places. I did not introduce this variable in the original commit because the check was done at one place and it was possible to explain that in a comment there.Originally posted by @lassoan in #94 (comment)
The text was updated successfully, but these errors were encountered: