Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize per-platform support introducing PLATFORM_SUPPORTS_VR option #95

Closed
jcfr opened this issue Apr 28, 2022 · 1 comment · Fixed by #149
Closed

Generalize per-platform support introducing PLATFORM_SUPPORTS_VR option #95

jcfr opened this issue Apr 28, 2022 · 1 comment · Fixed by #149

Comments

@jcfr
Copy link
Contributor

jcfr commented Apr 28, 2022

Thank you, looks good. Nitpick: instead of using if(APPLE) at two different places, it would be nicer to set a variable like PLATFORM_SUPPORTS_VR once (set it to FALSE if APPLE, TRUE otherwise) and use that value at both places. I did not introduce this variable in the original commit because the check was done at one place and it was possible to explain that in a comment there.

Originally posted by @lassoan in #94 (comment)

@jcfr
Copy link
Contributor Author

jcfr commented Dec 30, 2023

To enable the support for specific runtime, there is now the following CMake options:

  • SlicerVirtualReality_HAS_OPENVR_SUPPORT
  • SlicerVirtualReality_HAS_OPENXR_SUPPORT

By default, both OpenXR and OpenVR are now disabled on macOS:

At runtime, there is also the XRRuntime property associated with the view node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant