Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

environment variable to save configured settings in a file #188

Open
lunarpapillo opened this issue Mar 18, 2024 · 5 comments
Open

environment variable to save configured settings in a file #188

lunarpapillo opened this issue Mar 18, 2024 · 5 comments
Assignees

Comments

@lunarpapillo
Copy link

Some application vendors configure the validation layer programmatically (i.e. via switches like -vulkan_enable_validation -vulkan_enable_sync_validation etc.).

For local analysis, it would be very helpful to know exactly how the validation layer is actually being configured in these cases.

Defining an environment variable VK_VALIDATION_SAVE_SETTINGS=/path/to/file/to/save/settings that caused VVL to write a settings file to the given location would make it easy.

@lunarpapillo lunarpapillo added the enhancement New feature or request label Mar 18, 2024
@spencer-lunarg spencer-lunarg self-assigned this Mar 19, 2024
@spencer-lunarg
Copy link
Contributor

agree, this is also nice in general as sometimes I myself am concern I do/don't have certain settings enabled... VK_LAYER_VALIDATION_SAVE_SETTINGS would be a good debug env variable

@charles-lunarg
Copy link
Collaborator

Would this be something to add to the settings library instead of being specific to validation?

@spencer-lunarg
Copy link
Contributor

@christophe-lunarg this is something we really want for other layers too, is this something Layer Settings can take care of?

@christophe-lunarg
Copy link
Contributor

This looks great to me and yes the layer settings library is a good place for this to generalize to all layers.
We could also have a VK_VALIDATION_LOAD_SETTINGS env variable.

Probably a bit tricky to handle correcly the interaction of multiple layers on that file. I think we should go for a single environment variable VK_LAYERS_LOAD_SETTINGS and VK_LAYERS_SAVE_SETTINGS shared across layers.

Does it sounds good to you?

Should we move this issue in the VulkanUtility repository?

@spencer-lunarg spencer-lunarg transferred this issue from KhronosGroup/Vulkan-ValidationLayers Mar 21, 2024
@spencer-lunarg
Copy link
Contributor

Does it sounds good to you?

Sounds good to me, @lunarpapillo good for you?

Should we move this issue in the VulkanUtility repository?

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants