Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused helper function #46

Open
NecdetYavas opened this issue Jul 11, 2024 · 1 comment
Open

Unused helper function #46

NecdetYavas opened this issue Jul 11, 2024 · 1 comment
Assignees

Comments

@NecdetYavas
Copy link

I'm still new at Vulkan and followed the tutorial until multisampling. During deph buffering chapter we create a helper function:

bool hasStencilComponent(VkFormat format) {
return format == VK_FORMAT_D32_SFLOAT_S8_UINT || format == VK_FORMAT_D24_UNORM_S8_UINT;
}

But in the source code, it's not used anywhere.

@SaschaWillems
Copy link
Collaborator

Thanks for bringing this up.

The function itself could be used to check if you have a pure depth format with no stencil part. In such a case, you need to use different image aspects in some places.

But this is indeed not used in any of the source files. I'll look into this.

@SaschaWillems SaschaWillems self-assigned this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants