Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the device selection part of the tutorial #12

Open
SaschaWillems opened this issue Sep 8, 2023 · 1 comment
Open

Rework the device selection part of the tutorial #12

SaschaWillems opened this issue Sep 8, 2023 · 1 comment
Assignees

Comments

@SaschaWillems
Copy link
Collaborator

Right now it does some "sustainability" check that doesn't really make sense. It prefers devices with geometry shader support (though it's nowhere used in the tutorial) and calculates some score based on min. 2D image size.

See https://vulkan-tutorial.com/Drawing_a_triangle/Setup/Physical_devices_and_queue_families#page_Base-device-suitability-checks

That's very misleading and many people just copy it . For something like a tutorial it would be best to just have the user select the device from a list of available devices.

Note: Copied from the old repo's project board

@SaschaWillems
Copy link
Collaborator Author

We really should redo this. This often comes up on Discord as people think calculating a score like shown in the tutorial is a good idea, leading to lots of confusion.

@SaschaWillems SaschaWillems self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant