Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists.txt logic for finding dxc has deficiencies #1081

Open
SRSaunders opened this issue Jul 2, 2024 · 0 comments
Open

CMakeLists.txt logic for finding dxc has deficiencies #1081

SRSaunders opened this issue Jul 2, 2024 · 0 comments

Comments

@SRSaunders
Copy link

Two issues found with the CMakeLists logic for finding dxc:

  1. project(vulkan_samples) is called after find_package(Vulkan) which is incorrect. This results in default platform search paths not being set up properly for find_package() and dxc is not found unless VULKAN_SDK is defined ahead of time in the shell. This is awkward and unnecessary on Windows, and does not support system-wide installations on macOS and linux.
  2. The test for Vulkan_dxc_EXECUTABLE should be if(Vulkan_dxc_EXECUTABLE) and not if(DEFINED Vulkan_dxc_EXECUTABLE). The latter test erroneously passes even if Vulkan_dxc_EXECUTABLE-NOTFOUND is the result from find_package() or find_program().

I will submit a fix that corrects these as part of larger PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant