Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mipmaps import setting is ignored for KTX textures (one-line fix) #752

Closed
katas94 opened this issue Jul 8, 2024 · 0 comments
Closed

Mipmaps import setting is ignored for KTX textures (one-line fix) #752

katas94 opened this issue Jul 8, 2024 · 0 comments

Comments

@katas94
Copy link

katas94 commented Jul 8, 2024

I noticed that setting the GenerateMipMapsForTextures setting on the GLTFSceneImporter has no effect for KTX textures. It can be easily fixed by using the mipChain parameter when loading the KTX texture on ImporterTextures.cs:167

var resultTextureData = await ktxTexture.LoadFromBytes(data, isLinear, mipChain: GenerateMipMapsForTextures);

Since I don't have all the context I'm not sure if the setting should be added elsewhere for other cases.

hybridherbst pushed a commit to prefrontalcortex/UnityGLTF that referenced this issue Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant