Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Clean up and minor refactor #1802

Open
3 of 11 tasks
theamanjs opened this issue Jul 7, 2023 · 0 comments
Open
3 of 11 tasks

Code Clean up and minor refactor #1802

theamanjs opened this issue Jul 7, 2023 · 0 comments
Assignees

Comments

@theamanjs
Copy link
Collaborator

theamanjs commented Jul 7, 2023

Code cleanup tasks

  • Should add proptypes to the files where it’s missing
  • File: SearchContent.jsx line:62 we are using static string ‘all’ instead that should some from banidb.js file. Should replace the static strings at all the places.
  • File: MiscHeader.jsx line: 51 we are using static string this should some from i18n. Issues like that should be fixed, not limited to this file only.
  • File: MiscHeader.jsc line line: 36 we are passign static string to setTab file. Instead there should be a common js file in constants folder which should have all these tabs name and replace that variable in all the files that are using this static string. Not limited to the mentioned line number and file.
  • File: shortcut-functions.js is empty. Should be removed.
  • File: shortcut-map.json is no longer in use. Either we should find a way to use that again by separating the keyboard shortcut code from Launchpad.jsx file or remove it
  • File: shortcut_tray.json is not in use. Find a way to get that in use or remove it
  • File: viewer.json is empty. Remove or get in use
  • File: .prettierrc maybe not in use. Get that in use again
  • We can’t see new changes, without shutting down the server and starting again, it shouldn’t be this way. Some problem with how source maps are integrated; hot reload
  • Rename the content1, content2, content3 to something more specific Bug fixes and improvements #1969 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants