From cd5bd143c60225f9f99458188ba9becc018296a3 Mon Sep 17 00:00:00 2001 From: Gauravjeet Singh Date: Fri, 31 May 2024 18:05:38 -0400 Subject: [PATCH 1/3] fix: resolve the sundar gutka issue, whening opening multiple banis in multipane workspace --- www/main/navigator/shabad/ShabadText.jsx | 19 +++++++- .../navigator/shabad/utils/change-verse.js | 46 +++++++++++++++++-- 2 files changed, 60 insertions(+), 5 deletions(-) diff --git a/www/main/navigator/shabad/ShabadText.jsx b/www/main/navigator/shabad/ShabadText.jsx index 7b5bf91b..8ea8a0f7 100644 --- a/www/main/navigator/shabad/ShabadText.jsx +++ b/www/main/navigator/shabad/ShabadText.jsx @@ -63,6 +63,10 @@ export const ShabadText = ({ setVerseHistory, setActivePaneId, setShortcuts, + setSundarGutkaBaniId, + setCeremonyId, + setIsCeremonyBani, + setIsSundarGutkaBani, } = useStoreActions((actions) => actions.navigator); const [activeVerse, setActiveVerse] = useState({}); @@ -83,6 +87,15 @@ export const ShabadText = ({ activeShabadId, setActiveShabadId, setPreviousIndex, + baniType, + sundarGutkaBaniId, + setSundarGutkaBaniId, + ceremonyId, + setCeremonyId, + isSundarGutkaBani, + setIsSundarGutkaBani, + isCeremonyBani, + setIsCeremonyBani, }); udpateHistory(shabadId, newTraversedVerse, { verseHistory, @@ -163,8 +176,10 @@ export const ShabadText = ({ updateHomeVerse(initialVerseIndex); setActiveVerse({ [activeVerseIndex]: activeVerseId }); } - if (activeShabadId === null) { - updateTraversedVerse(initialVerseId, initialVerseIndex); + if (activeShabadId === null || sundarGutkaBaniId === null || ceremonyId === null) { + if (initialVerseIndex >= 0) { + updateTraversedVerse(initialVerseId, initialVerseIndex); + } } } }, [filteredItems]); diff --git a/www/main/navigator/shabad/utils/change-verse.js b/www/main/navigator/shabad/utils/change-verse.js index c4557882..d117a664 100644 --- a/www/main/navigator/shabad/utils/change-verse.js +++ b/www/main/navigator/shabad/utils/change-verse.js @@ -31,11 +31,51 @@ export const changeVerse = ( setActiveShabadId, activeShabadId, setPreviousIndex, + baniType, + sundarGutkaBaniId, + setSundarGutkaBaniId, + ceremonyId, + setCeremonyId, + isSundarGutkaBani, + setIsSundarGutkaBani, + isCeremonyBani, + setIsCeremonyBani, }, ) => { - if (clickedShabad !== activeShabadId) { - setActiveShabadId(clickedShabad); - setPreviousIndex(null); + if (baniType === 'bani') { + if (clickedShabad !== sundarGutkaBaniId) { + setSundarGutkaBaniId(clickedShabad); + setPreviousIndex(null); + } + if (!isSundarGutkaBani) { + setIsSundarGutkaBani(true); + } + if (isCeremonyBani) { + setIsCeremonyBani(false); + } + } else if (baniType === 'ceremony') { + if (clickedShabad !== ceremonyId) { + setCeremonyId(clickedShabad); + setPreviousIndex(null); + } + + if (!isSundarGutkaBani) { + setIsSundarGutkaBani(true); + } + if (isCeremonyBani) { + setIsCeremonyBani(false); + } + } else if (baniType === 'shabad') { + if (clickedShabad !== activeShabadId) { + setActiveShabadId(clickedShabad); + setPreviousIndex(null); + } + if (isSundarGutkaBani) { + setIsSundarGutkaBani(false); + } + if (isCeremonyBani) { + setIsCeremonyBani(false); + } } setActiveVerse({ [verseIndex]: newTraversedVerse }); if (activeVerseId !== newTraversedVerse) { From 97593acec263a120b5ef42ddf7e80b3e03334d08 Mon Sep 17 00:00:00 2001 From: Gauravjeet Singh Date: Fri, 31 May 2024 18:43:49 -0400 Subject: [PATCH 2/3] fix: resolve the active pane glitch when switching workspace --- www/main/navigator/shabad/ShabadText.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/main/navigator/shabad/ShabadText.jsx b/www/main/navigator/shabad/ShabadText.jsx index 8ea8a0f7..615a43db 100644 --- a/www/main/navigator/shabad/ShabadText.jsx +++ b/www/main/navigator/shabad/ShabadText.jsx @@ -176,7 +176,7 @@ export const ShabadText = ({ updateHomeVerse(initialVerseIndex); setActiveVerse({ [activeVerseIndex]: activeVerseId }); } - if (activeShabadId === null || sundarGutkaBaniId === null || ceremonyId === null) { + if (activeShabadId === null && sundarGutkaBaniId === null && ceremonyId === null) { if (initialVerseIndex >= 0) { updateTraversedVerse(initialVerseId, initialVerseIndex); } From 88f1468b3e169260711e6bee20d8ff32c659cebb Mon Sep 17 00:00:00 2001 From: Gauravjeet Singh Date: Fri, 31 May 2024 18:44:47 -0400 Subject: [PATCH 3/3] chore: exit the script and continue with build process --- packaging/update-packagejson.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/update-packagejson.js b/packaging/update-packagejson.js index f996b659..a8378f13 100644 --- a/packaging/update-packagejson.js +++ b/packaging/update-packagejson.js @@ -7,7 +7,7 @@ const teamId = process.env.APPLE_TEAM_ID; if (!teamId) { console.error('TEAM_ID is not defined in the environment variables'); - process.exit(1); + process.exit(0); } if (!process.env.I_AM_TRAVIS) {