-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Music notations typos #16
Comments
Further information / 补充资料: 「ドイツ語は英語とほぼ同様だが、「B」は英語の「B♭」に相当し、英語の「B」にあたる音は「H」と呼ぶ。派生音は♯をつける代わりに音名に「-is」を後置し、♭をつけるかわりに「-es」(母音のAとEの場合は単に「-s」)を後置する。」 Translation by ChatGPT:
Source / 来源:https://ja.wikipedia.org/wiki/%E9%9F%B3%E5%90%8D%E3%81%A8%E9%9A%8E%E5%90%8D |
Thanks for reporting!
Thanks for your corrections! They helped a lot :) |
我觉得这个能帮到你 十二律 这个和十二平均律很像,但是感觉很少人能看懂,宫商角徵羽更普遍一些吧。中式记法这里还是我欠考虑了 I think this can help you: Shi'er lü is quite similar to the twelve-tone equal temperament, but it seems that very few people can understand it. The names of the notes, 宫商角徵羽, are more commonly known. I realize I haven't considered enough here, sorry. |
I'll just keep it unchanged for now. ps: I made a mistake in the previous statements and here's the corrected one:
|
Mod Loader
Fabric
Minecraft Version
1.20.2
What Happened?
I reviewed your code NoteBlockData.java and found several typos in notations.
m -> m.map("Ais3", "H3"),
->m -> m.map("Ais3", "B3"),
m -> Text.literal("B3"),
->m -> Text.literal("H3"),
m -> m.map("Ais4", "H4"),
->m -> m.map("Ais4", "B4"),
m -> Text.literal("B4"),
->m -> Text.literal("H4"),
In germanic notations, B is actually B-flat, and H is actually B. Reference: Why is the musical scale C D E F G A H? Why is there an H between A and C instead of B?
二
->ニ
The former one in the code is actually Hanzi/Kanji character
U+4E8C
; the latter is Japanese KatakanaU+30CB
.I take "Chinese Pentatonic Scale" on Wikipedia as reference, I have not found that these "宫商角徵羽" can be connected with "升" and "降". Hope you can provide me further information.
Translations may be inaccurate or problematic, here is the Chinese version:
我看了你的 NoteBlockData.java 代码发现了一些音符记法上的问题。
m -> m.map("Ais3", "H3"),
->m -> m.map("Ais3", "B3"),
m -> Text.literal("B3"),
->m -> Text.literal("H3"),
m -> m.map("Ais4", "H4"),
->m -> m.map("Ais4", "B4"),
m -> Text.literal("B4"),
->m -> Text.literal("H4"),
根据我查找到的资料,在德式记法中 B 实际上指的是降 B,而 H 指的是 B。参考资料:Why is the musical scale C D E F G A H? Why is there an H between A and C instead of B?
二
->ニ
前者是汉字「二」
U+4E8C
,后者是日文片假名「ニ」。两者差距还是挺大的。根据 中国五声音阶 页面,我没看到有写可以升降。希望可以给更多资料解释一下。
What Should Happen?
No response
Steps to Reproduce
Not related to the reproduction process
与复现过程无关
Crash Log
No response
Anything Else?
No response
The text was updated successfully, but these errors were encountered: