Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate "Inactive contact deletion settings" module to V4 report #222

Open
6 tasks
ChristopherJennings opened this issue Apr 25, 2019 · 0 comments
Open
6 tasks

Migrate "Inactive contact deletion settings" module to V4 report #222

ChristopherJennings opened this issue Apr 25, 2019 · 0 comments
Assignees
@kentico-ericd
Labels
groomed Well-defined and ready to be worked on help wanted This is an opportunity for anyone to contribute report migration
Projects
Prioritization Kentico Inspector V4

Comments

@ChristopherJennings
Copy link
Contributor

Overview

We should migrate the Inactive contact deletion settings module to the new V4 report format.

Definition of done

  • Code and Scripts are ported to KenticoInspector.Reports project in a dedicated folder for the report.
  • Scripts are referenced via constants in a static class.
  • Scripts are refactored to return simple results that are mappable to simple classes.
  • Report logic is covered by unit test for a clean result
  • Report logic is covered by unit tests for all known dirty results
  • Useful, non-specific logic is abstracted to services or helpers.

Note: The Class/Table Validation report (and it's tests) is a good, simple example of the main concepts.

Additional Details

  • New name: Inactive Contact Deletion Analysis
  • Tags: Health, Online Marketing, Performance, Configuration
@ChristopherJennings ChristopherJennings added help wanted This is an opportunity for anyone to contribute groomed Well-defined and ready to be worked on report migration labels Apr 25, 2019
@ChristopherJennings ChristopherJennings added this to the 4.0 milestone Apr 25, 2019
@ChristopherJennings ChristopherJennings added this to To do in Kentico Inspector V4 via automation Apr 25, 2019
@ChristopherJennings ChristopherJennings added this to Priority in Prioritization via automation Apr 25, 2019
@ChristopherJennings ChristopherJennings moved this from Priority to Medium in Prioritization Apr 25, 2019
@kentico-ericd kentico-ericd removed this from the 4.0 milestone Aug 8, 2023
@kentico-ericd kentico-ericd self-assigned this Jun 7, 2024
kentico-ericd added a commit to kentico-ericd/KInspector that referenced this issue Jun 7, 2024
@kentico-ericd
InactiveContactSettingsSummary Kentico#222
d372e3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kentico-ericd kentico-ericd

Labels
groomed Well-defined and ready to be worked on help wanted This is an opportunity for anyone to contribute report migration
Projects
Kentico Inspector V4
  
To do
Prioritization
Medium
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChristopherJennings @kentico-ericd