Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: New SLF4J_GET_STACK_TRACE #70

Open
vorburger opened this issue Mar 14, 2018 · 0 comments
Open

RFE: New SLF4J_GET_STACK_TRACE #70

vorburger opened this issue Mar 14, 2018 · 0 comments

Comments

@vorburger
Copy link
Contributor

Separating out from original #69 :

We could have a new check which detects this kind of non-sense I'm seeing suprisingly often:

LOG.error("bla bla bla problem {}", e.getStackTrace())

@KengoTODA would you welcome a contribution for this, and deploy a new release with it if?
@vorburger vorburger mentioned this issue Mar 14, 2018
Open
vorburger added a commit to vorburger/findbugs-slf4j that referenced this issue Mar 14, 2018
@vorburger
factor AbstractDetectorForParameterArray2 out of ManualMessageDetector
d1a2c62 
so that in the next commit the upcoming ManualGetStackTraceDetector for
a SLF4J_GET_STACK_TRACE (issue KengoTODA#70) does not have to copy/paste 3/4 of
the ManualMessageDetector
vorburger added a commit to vorburger/findbugs-slf4j that referenced this issue Mar 14, 2018
@vorburger
add new SLF4J_GET_STACK_TRACE detector (fixes KengoTODA#70)
33f4abd
vorburger added a commit to vorburger/findbugs-slf4j that referenced this issue Mar 14, 2018
@vorburger
fix UsingGetStackTraceTest (KengoTODA#70)
d8ae99b
@vorburger vorburger mentioned this issue Mar 14, 2018
Open
vorburger added a commit to vorburger/findbugs-slf4j that referenced this issue Jul 23, 2018
@vorburger
factor AbstractDetectorForParameterArray2 out of ManualMessageDetector
e73b9a6 
so that in the next commit the upcoming ManualGetStackTraceDetector for
a SLF4J_GET_STACK_TRACE (issue KengoTODA#70) does not have to copy/paste 3/4 of
the ManualMessageDetector
vorburger added a commit to vorburger/findbugs-slf4j that referenced this issue Jul 23, 2018
@vorburger
add new SLF4J_GET_STACK_TRACE detector (fixes KengoTODA#70)
7c819fa 
incl. adjustments for code review feedback

* delete useless inline comment
* add @Item.SpecialKind annotation
* rename getIsOfInterestKind to getKindOfInterest
* rename isGetStackTrace to getStackTraceKind
* rename AbstractDetectorForParameterArray2 to AbstractExtendedDetectorForParameterArray
vorburger added a commit to vorburger/findbugs-slf4j that referenced this issue Jul 24, 2018
@vorburger
factor AbstractDetectorForParameterArray2 out of ManualMessageDetector
a9380ef 
so that in the next commit the upcoming ManualGetStackTraceDetector for
a SLF4J_GET_STACK_TRACE (issue KengoTODA#70) does not have to copy/paste 3/4 of
the ManualMessageDetector
vorburger added a commit to vorburger/findbugs-slf4j that referenced this issue Jul 24, 2018
@vorburger
add new SLF4J_GET_STACK_TRACE detector (fixes KengoTODA#70)
b0d7d80 
incl. adjustments for code review feedback

* delete useless inline comment
* add @Item.SpecialKind annotation
* rename getIsOfInterestKind to getKindOfInterest
* rename isGetStackTrace to getStackTraceKind
* rename AbstractDetectorForParameterArray2 to AbstractExtendedDetectorForParameterArray
vorburger added a commit to vorburger/findbugs-slf4j that referenced this issue Feb 5, 2019
@vorburger
factor AbstractDetectorForParameterArray2 out of ManualMessageDetector
f5e4b0f 
so that in the next commit the upcoming ManualGetStackTraceDetector for
a SLF4J_GET_STACK_TRACE (issue KengoTODA#70) does not have to copy/paste 3/4 of
the ManualMessageDetector
vorburger added a commit to vorburger/findbugs-slf4j that referenced this issue Feb 5, 2019
@vorburger
add new SLF4J_GET_STACK_TRACE detector (fixes KengoTODA#70)
75fbe0c 
incl. adjustments for code review feedback

* delete useless inline comment
* add @Item.SpecialKind annotation
* rename getIsOfInterestKind to getKindOfInterest
* rename isGetStackTrace to getStackTraceKind
* rename AbstractDetectorForParameterArray2 to AbstractExtendedDetectorForParameterArray
vorburger added a commit to vorburger/findbugs-slf4j that referenced this issue Feb 5, 2019
@vorburger
factor AbstractDetectorForParameterArray2 out of ManualMessageDetector
cfa372b 
so that in the next commit the upcoming ManualGetStackTraceDetector for
a SLF4J_GET_STACK_TRACE (issue KengoTODA#70) does not have to copy/paste 3/4 of
the ManualMessageDetector
vorburger added a commit to vorburger/findbugs-slf4j that referenced this issue Feb 5, 2019
@vorburger
add new SLF4J_GET_STACK_TRACE detector (fixes KengoTODA#70)
0841ad7 
incl. adjustments for code review feedback

* delete useless inline comment
* add @Item.SpecialKind annotation
* rename getIsOfInterestKind to getKindOfInterest
* rename isGetStackTrace to getStackTraceKind
* rename AbstractDetectorForParameterArray2 to AbstractExtendedDetectorForParameterArray
@xurror xurror mentioned this issue Mar 2, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vorburger