Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclusion pattern doesn't work (the .kavitaignore replacement) #3402

Open
janaxhell opened this issue Nov 24, 2024 · 1 comment
Open

Exclusion pattern doesn't work (the .kavitaignore replacement) #3402

janaxhell opened this issue Nov 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@janaxhell
Copy link

What happened?

According to the wiki

**/folder/* will ignore the folder at any depth in a path

I have many series folders that contain an /Extra subfolder with HTML presentation full of gifs/jpegs and such. With .kavitaignore I used Extra/* and all seemed to work fine. Now I have tried the same pattern in the UI, but it doesn't work, so I tried the above example as **/Extra/*
and it doesn't work as well. I have manually removed the bogus "series", rescanned with that exclusion and they came back.
My hierarchy is
/comics/country/publisher/series/Extra
with all the .cbz files at the same level of /Extra in
/comics/country/publisher/series/

image

I'm using latest 0.8.4.0

What did you expect?

To not see bogus series thumbnails appear among legit series.
I.e I have a real series folder called "L'Eternauta" inside which there is a subfolder called /Extra, containing HTML presentation
In the UI I now see a legit "L'Eternauta" entry with the first issue cover thumbnail and a second "L'Eternauta" entry showing a random pic from the HTML content inside /Extra.
With .kavitaignore I could filter that out.

Kavita Version Number - If you don not see your version number listed, please update Kavita and see if your issue still persists.

0.8.4 - Stable

What operating system is Kavita being hosted from?

Docker (Other)

If the issue is being seen on Desktop, what OS are you running where you see the issue?

None

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Other (List in "Additional Notes" box)

If the issue is being seen on Mobile, what OS are you running where you see the issue?

None

If the issue is being seen on the Mobile UI, what browsers are you seeing the problem on?

No response

Relevant log output

No response

Additional Notes

No response

@janaxhell janaxhell added the needs-triage Needs to be triaged by a developer and assigned a release label Nov 24, 2024
@majora2007 majora2007 added bug Something isn't working and removed needs-triage Needs to be triaged by a developer and assigned a release labels Nov 25, 2024
@majora2007
Copy link
Member

I was able to reproduce this. I do see a few potential points of failure:

  1. The matcher was missing on some flows when scanning for files/folders
  2. There may be some mismatch with slashes that I need to handle better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants