Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache songs instead of downloading externally. #709

Open
1 task done
devanarayanan44 opened this issue Sep 10, 2023 · 9 comments
Open
1 task done

Cache songs instead of downloading externally. #709

devanarayanan44 opened this issue Sep 10, 2023 · 9 comments
Labels
enhancement New feature or request

Comments

@devanarayanan44
Copy link

devanarayanan44 commented Sep 10, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Pain

If I download a song and play it from the artist page or from a playlist, it plays online. I can't view the lyrics of downloaded tracks.
I can't go to the album or artist from the downloaded tracks.

Suggested solution

Cache the songs (like inner tune) and add a separate option for downloading externally.

Useful resources

No response

Additional information

No response

@devanarayanan44 devanarayanan44 added the enhancement New feature or request label Sep 10, 2023
@KRTirtho
Copy link
Owner

Does caching music really make sense?
Most of the users doesn't listen to the same song twice in a day (or even weeks) without special reason. So if we cache songs (save them on the storage) we also must need to set a custom cache limit after which old songs will get removed
So if songs are getting added constantly & old ones are getting removed to make space then is there any point of caching here?
We're doing nothing but wasting space in glorified way. Which official Spotify app does a lot btw (over 2-3GB occupied cache space)

Btw caching song is a really tough thing to implement & time consuming (implementation for each platform)

@ZenKyma
Copy link

ZenKyma commented Sep 11, 2023

I assume the idea is to have a button to make tracks available offline (apart from download) for listening through spotube and enjoying the lyrics, by caching the respective content.
The problem of a cache limit would be eliminated if the user has to manage his cached content himself, e.g. through the respective button, a more advanced option would be a 'cached-content' interface.

Actually this was the behaviour I also expected when first seeing the download option.

@devanarayanan44
Copy link
Author

devanarayanan44 commented Sep 11, 2023

I assume the idea is to have a button to make tracks available offline (apart from download) for listening through spotube

Exactly.

@siggi1984
Copy link
Contributor

Does caching music really make sense? Most of the users doesn't listen to the same song twice in a day (or even weeks) without special reason. So if we cache songs (save them on the storage) we also must need to set a custom cache limit after which old songs will get removed So if songs are getting added constantly & old ones are getting removed to make space then is there any point of caching here? We're doing nothing but wasting space in glorified way. Which official Spotify app does a lot btw (over 2-3GB occupied cache space)

Btw caching song is a really tough thing to implement & time consuming (implementation for each platform)

A song cache function would be very useful and helpful. I would be very happy about such a function.

@AozoraDev
Copy link

Caching is probably useful, since i'm always listening to my Liked Tracks....
I mean... i know i can use mass download but it's kind of pain in the ass imo.

@OmG3r
Copy link

OmG3r commented Oct 19, 2023

an alternative/enhancement is to simply offer a setting to download all songs you listen to by default, songs will be available in the download specified

@KRTirtho
Copy link
Owner

KRTirtho commented Jul 9, 2024

It's actually somewhat possible now since spotube now uses a custom streaming proxy inside the app, so we could cache the stream in file. It might occupy more storage.

@ZenKyma
Copy link

ZenKyma commented Jul 9, 2024

Great news! It's totally expected to occupy storage when you cache music locally, I guess that's the deal for enjoying it offline ;)

@siggi1984
Copy link
Contributor

It's actually somewhat possible now since spotube now uses a custom streaming proxy inside the app, so we could cache the stream in file. It might occupy more storage.

Does that mean that the songs you listen to are saved and can be played offline the next time you play them? That would be great and would save mobile data for those who don't have that much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

6 participants