Fix fill_tiled segfault #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThe PR fixes a segfault in the fill_tiled function by introducing a temporary layout and cell to handle fill operations. Instead of directly modifying the target cell during the filling process, the changes are first applied to a temporary cell and then transferred to the target cell in a controlled manner. Sequence diagram for fill_tiled function changessequenceDiagram
participant FillOperator
participant temp_ly as Temporary Layout
participant temp_tc as Temporary Cell
participant top_cell as Top Cell
participant fill_cell as Fill Cell
fill_tiled->>FillOperator: Create FillOperator instance
FillOperator->>temp_ly: Start changes
FillOperator->>temp_tc: fill_region_multi or fill_region
FillOperator->>temp_ly: End changes
FillOperator->>temp_tc: Iterate each_inst
temp_tc->>top_cell: Insert cell_inst_array
fill_tiled->>FillOperator: insert_fill()
FillOperator->>top_cell: Insert fill cell into regions
Class diagram for FillOperator changesclassDiagram
class FillOperator {
+list<kdb.Cell> filled_cells
+kdb.Layout temp_ly
+kdb.Cell temp_tc
+kdb.Cell temp_fc
+int temp_fc_ind
+void insert_fill()
}
FillOperator : fill_region_multi(region, fill_cell_index, fc_bbox, row_step, column_step, fill_margin, glue_box)
FillOperator : fill_region(region, fill_cell_index, fc_bbox, row_step, column_step, fill_margin, glue_box)
note for FillOperator "New attributes and method added to handle temporary layout and cell operations"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
| cell_inst_array = inst.cell_inst | ||
| cell_inst_array.cell_index = self.fill_cell_index | ||
| self.top_cell.insert(cell_inst_array) | ||
|
|
||
|
|
||
| def fill_tiled( |
There was a problem hiding this comment.
issue (code-quality): We've found these issues:
- Split conditional into multiple branches [×2] (
split-or-ifs) - Merge duplicate blocks in conditional [×2] (
merge-duplicate-blocks) - Replace if statement with if expression (
assign-if-exp) - Remove redundant conditional (
remove-redundant-if) - Replace mutable default arguments with None (
default-mutable-arg) - Low code quality found in fill_tiled - 6% (
low-code-quality)
Explanation
The quality score for this function is below the quality threshold of 25%.
This score is a combination of the method length, cognitive complexity and working memory.
How can you solve this?
It might be worth refactoring this function to make it shorter and more readable.
- Reduce the function length by extracting pieces of functionality out into
their own functions. This is the most important thing you can do - ideally a
function should be less than 10 lines. - Reduce nesting, perhaps by introducing guard clauses to return early.
- Ensure that variables are tightly scoped, so that code using related concepts
sits together within the function rather than being scattered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix KLayout/klayout#1929
Summary by Sourcery
Bug Fixes: