Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Validator requirement For Publisher #82

Open
3 tasks
charsme opened this issue Aug 10, 2018 · 1 comment
Open
3 tasks

Custom Validator requirement For Publisher #82

charsme opened this issue Aug 10, 2018 · 1 comment
Assignees
@charsme @kennykarnama
Labels
enhancement New feature or request
Milestone
reversable

Comments

@charsme
Copy link
Contributor

charsme commented Aug 10, 2018

Need feature to validate entities before sending to one
Cases

  • don't send any article that don't have vertical image
  • some publisher should only send gallery article

Solutions
Defined preset with condition when implementing One\Publisher

  • Implementation for version 2
  • Implementation for version 1
  • Separate testing for this feature
@charsme charsme added the enhancement New feature or request label Aug 10, 2018
@charsme charsme added this to the reversable milestone Aug 10, 2018
@charsme charsme self-assigned this Aug 10, 2018
@charsme
Copy link
Contributor Author

charsme commented Aug 14, 2018

Scheme wished:

  • new namespace folder One\Validator
  • Create ValidatorInterface with validate function return boolean
  • Create premade Class with needed validated element.
  • Put in option when instantiate Publisher
  • Don't send article if entity didn't fullfill validator scheme
  • Create options if we need to throw exception or not
  • Create exception class for unfulfilled validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charsme charsme

@kennykarnama kennykarnama

Labels
enhancement New feature or request
Projects
ONE SDK roadmap
Status: To do
Milestone
reversable
Development

No branches or pull requests
2 participants
@charsme @kennykarnama