Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the naming module everywhere #939

Open
Tracked by #937
LeonMatthesKDAB opened this issue Apr 19, 2024 · 2 comments
Open
Tracked by #937

Use the naming module everywhere #939

LeonMatthesKDAB opened this issue Apr 19, 2024 · 2 comments
Labels
🪲 bug Something isn't working 👷 refactor Something needs to change

Comments

@LeonMatthesKDAB
Copy link
Collaborator

This module is more complete than our previous CombinedIdent approach.

Make sure to use it everywhere, especially in generation.
@LeonMatthesKDAB LeonMatthesKDAB mentioned this issue Apr 19, 2024
Open
4 tasks
@LeonMatthesKDAB LeonMatthesKDAB added 🪲 bug Something isn't working 👷 refactor Something needs to change labels Apr 19, 2024
@LeonMatthesKDAB LeonMatthesKDAB mentioned this issue Apr 24, 2024
Merged
@LeonMatthesKDAB LeonMatthesKDAB mentioned this issue May 13, 2024
Merged
LeonMatthesKDAB added a commit to LeonMatthesKDAB/cxx-qt that referenced this issue May 17, 2024
@LeonMatthesKDAB
refactor: QObjectName now uses naming::Name
7add067 
Part of KDAB#939
@LeonMatthesKDAB LeonMatthesKDAB mentioned this issue May 17, 2024
Merged
LeonMatthesKDAB added a commit to LeonMatthesKDAB/cxx-qt that referenced this issue May 21, 2024
@LeonMatthesKDAB
refactor: QObjectName now uses naming::Name
402573c 
Part of KDAB#939
LeonMatthesKDAB added a commit to LeonMatthesKDAB/cxx-qt that referenced this issue May 23, 2024
@LeonMatthesKDAB
refactor: QObjectName now uses naming::Name
22b76f3 
Part of KDAB#939
LeonMatthesKDAB added a commit to LeonMatthesKDAB/cxx-qt that referenced this issue Jun 3, 2024
@LeonMatthesKDAB
refactor: QObjectName now uses naming::Name
09ba11d 
Part of KDAB#939
ahayzen-kdab pushed a commit that referenced this issue Jun 3, 2024
@LeonMatthesKDAB @ahayzen-kdab
refactor: QObjectName now uses naming::Name
d893756 
Part of #939
@BenFordTytherington
Copy link
Contributor

CombinedIdent has now been completely removed from the codebase as of PR #1005

@LeonMatthesKDAB
Copy link
Collaborator Author

CombinedIdent has now been completely removed from the codebase as of PR #1005

Awesome!
I'll still go through the codebase and check whether there's places where we need to replace some more Ident instances with Name, but after that we can close this issue 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪲 bug Something isn't working 👷 refactor Something needs to change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LeonMatthesKDAB @BenFordTytherington