Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address URLs that the BBL endpoint redirects to aren't always valid #343

Open
toolness opened this issue Jul 27, 2020 · 0 comments
Open

Comments

@toolness
Copy link
Contributor

An example of this is BODY OF WATER. Apparently the Hudson River, or part of it, has a BBL. When WoW's front-end has to create a "human readable" URL for the BBL, it asks WoW's building info API endpoint, which looks up the BBL in PLUTO. The street address given by PLUTO is "BODY OF WATER", which WoW uses to construct the human-friendly URL:

https://demo-whoownswhat.justfix.nyc/en/address/MANHATTAN/BODY/OF%20WATER

However, loading this URL "cold" (copy-pasting it into another tab) results in an exception being thrown in the console, because on "cold start" WoW will look up "BODY OF WATER" in NYC Planning Labs Geosearch, which yields no results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant