Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas for language variant selections #60

Open
denismaier opened this issue Apr 5, 2019 · 5 comments
Open

Ideas for language variant selections #60

denismaier opened this issue Apr 5, 2019 · 5 comments

Comments

@denismaier
Copy link

denismaier commented Apr 5, 2019

Currently, non-fullnote note styes produce an superflous secondary element on position=first. The question is if this behaviour can be changed. One option would be a gui setting to suppress this, but the preference menu is currently being redesigned for ReactJs on the Zotero side, so any GUI improvements will take some time.

So perhaps in the meantime it might be an option to define the language variant patterns using some plain text style files, just like CSL styles? I agree that an intuitive UI would be amazing, something like the drag-and-drop selector Frank describes here. On the other hand, it's perhaps easier without GUI constraints. I am thinking of something like this:

<variants>
  <titles primary="transliteration" secondary="original" secondary-affixes="brackets"/>
</variants>

This could be easily extended with more nodes allowing for different settings in notes and in the bibliography.

<variants>
  <bibliography>
    <titles primary="transliteration" secondary="original" secondary-affixes="brackets"/>
  </bibliography>
  <notes>
    <titles primary="transliteration"/ >
  </notes>
</variants>

Or even:

<variants>
  <bibliography>
    <titles primary="transliteration" secondary="original" secondary-affixes="brackets"/>
  </bibliography>
  <notes>
    <first>
      <titles primary="transliteration" secondary="original" secondary-affixes="brackets"/ >
    </first>
    <subsequent>
      <titles primary="transliteration"/ >
    </subsequent>
  </notes>
</variants>

Obviously, a GUI is more intuitive, but given that CSL works similarly, such an approach might also be justifiable, at least if reactifying the menu is the issue. Also, I don't have the impression that this is utterly complex.

@fbennett
Copy link

fbennett commented Apr 9, 2019

We can look at adding a toggle in the current UI to suppress secondary forms on citations. If that will satisfy requirements, it's not super-hard to stir in.

@denismaier
Copy link
Author

Yes, that sounds like a good idea. I don't think we can come up with a way to suppress automatically without getting into trouble. One possible automatic way would be a test like "if there is no element with if position=first under cs:citation then suppress secondary forms on citations. But I would think that this is very error-prone and easily breakable... So a checkbox in the current UI sounds like the best solution.

@fbennett
Copy link

fbennett commented Jul 4, 2020

Sorry for leaving this for quite a long time. Looking back over the issue, I think I would need specific output examples to work from, before attempting to address it.

@denismaier
Copy link
Author

Here too, thanks for coming back to this. I can prepare some examples next week.

@denismaier
Copy link
Author

Let's say we have this a bibliographic reference like so:

A. Author. This is a title [with a variant]. Publisher 2020.

In a non-fullnote style, I wouldn't expect the variant to be rendered in the first citation. Instead, I'd expect this:

Author, This is a title.

But even in a fullnote style, you might want to have the variants only in the bibliography. So you might want this in the citations:

A. Author. This is a title. Publisher 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants