Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay issue on 1.17+ clients through 1.8 server(viaversion) #93

Open
MrF1yn opened this issue May 11, 2022 · 5 comments
Open

Replay issue on 1.17+ clients through 1.8 server(viaversion) #93

MrF1yn opened this issue May 11, 2022 · 5 comments

Comments

@MrF1yn
Copy link

MrF1yn commented May 11, 2022

On playing a replay on a 1.8server from a 1.18-1.17 client the player npc doesnt spawn,
block actions are still visible.
This issue disappears on playing the replay from a 1.16.5 client which means that something has changed related to npc spawn packets in 1.18-1.17.

Would really be glad if this issue is fixed since a lot of minigames servers run 1.8 server forks along with viaversion for increased performance.

@MrF1yn
Copy link
Author

MrF1yn commented May 11, 2022

Update:
i watched the replay from another account and it worked!
When I joined from both account and watched again it failed with the duplicate uuid warning which makes sense now that the client is ignoring duplicate packets

@MrF1yn
Copy link
Author

MrF1yn commented May 11, 2022

Which basically means that instead of using the actual uuid,eid of the original player it needs to be replaced with a counterfiet for the client to render it.

@Jumper251
Copy link
Owner

Maybe a config option that when enabled always uses the 1.18 way of spawning npcs could fix this.

@MrF1yn
Copy link
Author

MrF1yn commented May 11, 2022

Or maybe directly integrate into viaversion and check the client's version then do the spawning according to it. A more handsfree experience

@MrF1yn
Copy link
Author

MrF1yn commented May 12, 2022

Made a pull request addressing the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants