-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flattening retains empty testsets with new properties #102
Conversation
Cherry-picked the commits from #99 to assist in debugging the CI failure by eliminating those errors. Not sure about why it appears the Update: I forgot to update the total test count in the pre-1.7 reference file. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 94.69% 91.46% -3.24%
==========================================
Files 7 7
Lines 547 527 -20
==========================================
- Hits 518 482 -36
- Misses 29 45 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. I just realized you are part of the org.
So feel free to merge this when you are happy
Looks like the CI jobs are stuck on CodeCov reporting. Maybe updating to use the latest GHA will allow the jobs to complete. |
Co-authored-by: Frames White <[email protected]>
Mostly convenient for testing purposes. Overall I think this behavior is more intuitive in that if someone sets a property on a testset they would expect to appear in the generated report.