Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flattening retains empty testsets with new properties #102

Merged
merged 11 commits into from
Apr 29, 2024

Conversation

omus
Copy link
Member

@omus omus commented Apr 26, 2024

Mostly convenient for testing purposes. Overall I think this behavior is more intuitive in that if someone sets a property on a testset they would expect to appear in the generated report.

@omus
Copy link
Member Author

omus commented Apr 26, 2024

Cherry-picked the commits from #99 to assist in debugging the CI failure by eliminating those errors. Not sure about why it appears the "test_with_properties.txt" reference works fine locally but breaks on CI currently.

Update: I forgot to update the total test count in the pre-1.7 reference file.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.46%. Comparing base (f228a7a) to head (6f90b10).
Report is 1 commits behind head on master.

❗ Current head 6f90b10 differs from pull request most recent head c9d5f09. Consider uploading reports for the commit c9d5f09 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   94.69%   91.46%   -3.24%     
==========================================
  Files           7        7              
  Lines         547      527      -20     
==========================================
- Hits          518      482      -36     
- Misses         29       45      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. I just realized you are part of the org.
So feel free to merge this when you are happy

src/testsets.jl Outdated Show resolved Hide resolved
@omus
Copy link
Member Author

omus commented Apr 29, 2024

Looks like the CI jobs are stuck on CodeCov reporting. Maybe updating to use the latest GHA will allow the jobs to complete.

Co-authored-by: Frames White <[email protected]>
@omus omus merged commit 1ada409 into master Apr 29, 2024
10 checks passed
@omus omus deleted the cv/keep-testsets-with-properties branch April 29, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants