Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

porting to JuliaTesting #54

Closed
johnnychen94 opened this issue Jun 21, 2020 · 9 comments
Closed

porting to JuliaTesting #54

johnnychen94 opened this issue Jun 21, 2020 · 9 comments

Comments

@johnnychen94
Copy link
Member

This idea is originally proposed by @oxinabox in slack

@Evizero
Copy link
Member

Evizero commented Jun 21, 2020

I am happy to press the transfer button at any time really. Main reason I didn't do that yet, is because I am not sure if it can break anything. However, I am not up to speed about any other steps that need to be taken and would appreciate someone else performing them if possible.

@johnnychen94
Copy link
Member Author

The old URL is still valid even if it's transferred to a new place. We've transferred ImageContrastAdjustment to Images recently, and it's:

  1. hit the transfer button
  2. update CI settings

Ref: JuliaImages/Images.jl#855 (comment)

@oxinabox
Copy link
Member

Update the URL in the registry too for completeness.
(Even though it will redirect until something else (like a fork) is put at old URL)
Full instructions:
https://github.com/JuliaRegistries/General#how-do-i-transfer-a-package-to-an-organization-or-another-user

@johnnychen94
Copy link
Member Author

johnnychen94 commented Jun 21, 2020

I'll fix the CI and submit a PR to General later today/tomorrow.

@Evizero
Copy link
Member

Evizero commented Jun 21, 2020

I pushed the button. welcome to your new home, old friend.

Thank you two! This is surely the right place. It was your contributions that turned it into a proper package after all

@johnnychen94
Copy link
Member Author

johnnychen94 commented Jun 22, 2020

CI fixed in #56

The documentation tags for v0.9.0 and v0.9.1 are missing due to Travis grammar changes months ago(IIUC it's the cause), but that's not a big deal; as long as we tag a new v0.9.2 version, there will be a v0.9 tag.

@kimikage
Copy link

@johnnychen94
Copy link
Member Author

johnnychen94 commented Aug 10, 2020

Yes, the documentation definitely needs an update, I plan to do that after #61

Currently, the documentation is basically identical to README.md

@kimikage
Copy link

It's an issue with the broken link, not the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants