Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap to 1.0? #18

Open
1 task
DilumAluthge opened this issue Mar 16, 2021 · 2 comments
Open
1 task

Roadmap to 1.0? #18

DilumAluthge opened this issue Mar 16, 2021 · 2 comments

Comments

@DilumAluthge
Copy link
Member

DilumAluthge commented Mar 16, 2021

Are there any more breaking changes to the public API that we'd like to make before releasing BrokenRecord.jl version 1.0.0?

cc: @christopher-dG

List of planned breaking changes:

  • Make the function you pass to playback take one ctx argument
@christopher-dG
Copy link
Member

There's one very breaking thing I want to do, which is to make the function you pass to playback take one ctx argument. And then you can do stuff like is_recording(ctx), is_playing(ctx), ignore_headers(ctx, ["Authorization"]), etc. instead of the "global" config that we currently have.

I was writing some tests for another package and found that I kind of needed that functionality.

@DilumAluthge
Copy link
Member Author

That sounds really useful. I've put it on the list.

Anything else come to mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants