Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disentangling mappings from their methods (anomaly, differentiation, integration, inversion) #10

Open
MathieuRoule opened this issue Mar 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@MathieuRoule
Copy link
Member

Right now, the methods used for numerical computations are somehow hardcoded and their parameters are all contained in the OrbitalParameters structure.
It would be great to free the following methods (probably using multi-dispatch ?):

  • anomaly (hardcoded to Hénon)
  • integration method (hardcoded to RK4 for actions and frequencies)
  • differentiation method (hardcoded to naive finite differences)
  • inversion method (hardcoded to Newton-Raphson)

One way to currently bypass this for a specific potential is to define all the mappings using multi-dispatch on the model type. This is already used for the analytic computations for Isochrone. However, this is not very convenient.

We should keep in mind the following requirements:

  • Signatures of the functions need to be the same (while, e.g., in some analytical cases, there is no real need for an 'inversion' method)
@MathieuRoule MathieuRoule added the enhancement New feature or request label Mar 5, 2024
@MathieuRoule MathieuRoule changed the title Disentangling mapping methods Disentangling mapping from their methods Mar 5, 2024
@MathieuRoule MathieuRoule changed the title Disentangling mapping from their methods Disentangling mappings from their methods (anomaly, differentiation, integration, inversion) Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant