Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interoperate with Base.@kwdef #33

Open
gafter opened this issue Mar 28, 2023 · 3 comments
Open

Interoperate with Base.@kwdef #33

gafter opened this issue Mar 28, 2023 · 3 comments
Labels
up next

Comments

@gafter
Copy link
Member

gafter commented Mar 28, 2023

@nystrom says in a comment on JuliaServices/AutoHashEqualsCached.jl#1:

Just FYI for when you process Base.@kwdef: fields in these structs can also be :(=) nodes with the field name and type in args[1] and the default value in args[2].
@gafter gafter mentioned this issue Mar 28, 2023
Merged
@gafter
Copy link
Member Author

gafter commented Mar 29, 2023

Also src/Compiler/Shared/auto-copy.jl in raicode

@gafter
Copy link
Member Author

gafter commented Apr 28, 2023

@kwdef also adds constructors that this package needs to be prepared to update.

@gafter gafter mentioned this issue Jun 20, 2023
Merged
@gafter gafter transferred this issue from JuliaServices/AutoHashEqualsCached.jl Aug 18, 2023
@gafter gafter mentioned this issue Aug 18, 2023
Closed
@gafter gafter added the up next label Aug 18, 2023
@gafter
Copy link
Member Author

gafter commented Oct 23, 2023

This will allow raicode to eliminate this comment:

# @auto_hash_equals is incompatible with @kwdef, so we have to roll our hash and equality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
up next
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gafter