Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interface when t0 != 0 #829

Open
schillic opened this issue Apr 27, 2024 · 0 comments
Open

Fix interface when t0 != 0 #829

schillic opened this issue Apr 27, 2024 · 0 comments

Comments

@schillic
Copy link
Member

For a time period t0 to t1, the following is used for TMJets:

dt = t0 .. t1
post(alg_TMJets, ivp, dt)

This works because TMJets reads out t0 from dt.

Other algorithms only read out the final time and instead a separate argument Δt0 for the offset must be passed:

t_span = zero(t0) .. (t1 - t0)
t_offset = interval(t0)
post(alg_other, ivp, t_span; Δt0=t_offset)

This interface is incompatible (one or the other crashes when the algorithm is flipped). We must fix this to be able to use different algorithms easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant