-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Subplot labeling. Fixes #998 #1331
Conversation
4b25d39
to
24ef12a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work @apalugniok !
src/components.jl
Outdated
# Give each annotation coordinates based on specified position | ||
function locate_annotation(sp::Subplot, pos::Symbol, lab::PlotText) | ||
position_multiplier = Dict{Symbol, Tuple{Float64,Float64}}( | ||
:top_left => (0.1, 0.9), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use versions without underscores (:topleft
, ...) here to be consistent with the position options for the legend
attribute.
The Plots way would probably be to allow both versions, as well as :t
, :tl
, :tr
, ... for annotations and legendpositions. This could be achieved by introducing a _positionAliases
Dict
and do some preprocessing in args.jl.
24ef12a
to
d79c66e
Compare
IMO we can merge this and open an issue for plotly. |
Hi! I just realized this convenience feature existed from the discourse posts! Is it documented in the API guide at all and I just missed it entirely? I could not find anything... |
I don't think it is documented |
#998
I opted for
ann = (:top_left, :auto)
instead ofann = :top
as it makes the processing easier.Note: