Fix ROCm-aware MPI extension #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this require a compat bounds update? How about a regression test? |
|
We
Yes, as already done in #755. But let's do it here as anything pre 0.5 would not run. |
|
@giordano I've updated combat bounds for AMDGPU.jl. There is no other functionality to do the regression testing against, this change just fixes the conversion of ROCArray to a Julia pointer, which didn't exist in AMDGPU prior to 0.5.7 |
|
Can we merge this and patch release? |
simonbyrne
reviewed
Sep 5, 2023
.gitignore
Outdated
Comment on lines
5
to
6
|
|
||
| .vscode/ |
There was a problem hiding this comment.
This should go in your own excludes file, see https://git-scm.com/docs/gitignore
simonbyrne
reviewed
Sep 5, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced with a recent update of AMDGPU.jl