Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODECOV_TOKEN to the corresponding GH Action #58

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

waldyrious
Copy link
Collaborator

@waldyrious waldyrious commented Jul 23, 2024

The upgrade from the Codecov GitHub Action from v3 to v4 done in #53 required the addition of the CODECOV_TOKEN environment variable to actually work — see #53 (comment).

I first went into the Codecov settings for this repo to obtain the token value, but then I realized that this variable is already available as a secret variable for GitHub Actions in the JuliaMath organization level. So the only thing that needs to be done (IIUC) is adding the line to GitHub Actions workflow .yml file specifying that the codecov-action should run with access to this secret — which is what this PR does.

@waldyrious waldyrious requested a review from giordano July 23, 2024 22:11
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.23%. Comparing base (e8a0d55) to head (c8e3366).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##            master      #58      +/-   ##
===========================================
- Coverage   100.00%   95.23%   -4.77%     
===========================================
  Files            1        1              
  Lines           13       21       +8     
===========================================
+ Hits            13       20       +7     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waldyrious
Copy link
Collaborator Author

waldyrious commented Jul 23, 2024

Looks like the presence of the codecov report comment above is proof enough that this is now working, but I'll wait for @giordano's approval :)

@waldyrious waldyrious merged commit 4881d46 into master Jul 23, 2024
10 of 11 checks passed
@waldyrious waldyrious deleted the fix-codecov branch July 23, 2024 22:19
This was referenced Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants