Fix REPL issue on Julia nightly #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `hint` keyword was added to the API of `complete_line`, and a corresponding positional argument was added to `bslash_completions`. This change adds the `hint` keyword to our method of `complete_line` and passes it along to `bslash_completions`, which is defined locally to accept and ignore the `hint` argument for earlier Julia versions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #541 +/- ##
==========================================
+ Coverage 80.22% 80.65% +0.43%
==========================================
Files 26 26
Lines 1699 1701 +2
==========================================
+ Hits 1363 1372 +9
+ Misses 336 329 -7 ☔ View full report in Codecov by Sentry. |
palday
approved these changes
Jul 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hintkeyword was added to the API ofcomplete_line, and a corresponding positional argument was added tobslash_completions. This change adds thehintkeyword to our method ofcomplete_lineand passes it along tobslash_completions, which is defined locally to accept and ignore thehintargument for earlier Julia versions.