Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos #494

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix typos #494

merged 1 commit into from
Jul 20, 2023

Conversation

musvaage
Copy link
Contributor

@musvaage musvaage commented Jul 19, 2023 •
edited
Loading

docs/src/installation.md
src/convert/default.jl
src/ijulia.jl
src/language.jl
src/methods.jl
src/render.jl
src/types.jl

@musvaage musvaage marked this pull request as draft July 19, 2023 01:45
palday
palday reviewed Jul 19, 2023
View reviewed changes
src/render.jl Outdated Show resolved Hide resolved
@musvaage musvaage marked this pull request as ready for review July 20, 2023 00:03
@musvaage
Copy link
Contributor Author

musvaage commented Jul 20, 2023 •
edited
Loading

implemented fix by @palday, did a soft reset and marked as ready for review

palday
palday approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@palday palday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution! The test failures all seem related to #495, so I'll go ahead and merge this.

@palday palday merged commit 7f59101 into JuliaInterop:master Jul 20, 2023
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palday palday palday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@musvaage @palday